371 lines
11 KiB
PHP
371 lines
11 KiB
PHP
<?php
|
|
|
|
namespace Tests\Feature\Web;
|
|
|
|
use Event;
|
|
use Facades\Tests\Setup\RoleFactory;
|
|
use Facades\Tests\Setup\UserFactory;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
use Vanguard\Events\Permission\Created;
|
|
use Vanguard\Events\Permission\Deleted;
|
|
use Vanguard\Events\Permission\Updated;
|
|
use Vanguard\Events\Role\PermissionsUpdated;
|
|
use Vanguard\Permission;
|
|
use Vanguard\Role;
|
|
|
|
class PermissionsTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
$this->artisan('db:seed');
|
|
|
|
$this->be(UserFactory::admin()->create());
|
|
}
|
|
|
|
/** @test */
|
|
public function permissions_list()
|
|
{
|
|
$permission = Permission::factory()->create();
|
|
|
|
$this->get('permissions')
|
|
->assertSee($permission->display_name);
|
|
}
|
|
|
|
/** @test */
|
|
public function only_users_with_appropriate_permissions_can_access_the_permissions_list_page()
|
|
{
|
|
$roleA = RoleFactory::create();
|
|
$roleB = RoleFactory::withPermissions('permissions.manage')->create();
|
|
|
|
$userA = UserFactory::role($roleA)->create();
|
|
$userB = UserFactory::role($roleB)->create();
|
|
|
|
$this->actingAs($userA)->get('/permissions')->assertStatus(403);
|
|
$this->actingAs($userB)->get('/permissions')->assertOk();
|
|
}
|
|
|
|
/** @test */
|
|
public function permission_list_with_roles()
|
|
{
|
|
$permission = Permission::factory()->create();
|
|
$role = Role::first();
|
|
|
|
$role->permissions()->attach($permission->id);
|
|
|
|
$this->get('permissions')
|
|
->assertSee($permission->display_name)
|
|
->assertSee("roles[$role->id][]");
|
|
}
|
|
|
|
/** @test */
|
|
public function save_role_permissions()
|
|
{
|
|
$this->withoutExceptionHandling();
|
|
|
|
Event::fake([
|
|
PermissionsUpdated::class,
|
|
]);
|
|
|
|
$permission = Permission::factory()->create();
|
|
$role = Role::factory()->create();
|
|
|
|
$this->post('permissions/save', [
|
|
'roles' => [
|
|
$role->id => [$permission->id],
|
|
],
|
|
]);
|
|
|
|
$this->assertSessionHasSuccess('Permissions saved successfully.');
|
|
|
|
$this->assertDatabaseHas('permission_role', [
|
|
'role_id' => $role->id,
|
|
'permission_id' => $permission->id,
|
|
]);
|
|
|
|
Event::assertDispatched(PermissionsUpdated::class);
|
|
}
|
|
|
|
/** @test */
|
|
public function only_users_with_appropriate_permissions_can_save_role_permissions()
|
|
{
|
|
$roleA = RoleFactory::create();
|
|
$roleB = RoleFactory::withPermissions('permissions.manage')->create();
|
|
|
|
$userA = UserFactory::role($roleA)->create();
|
|
$userB = UserFactory::role($roleB)->create();
|
|
|
|
$permission = Permission::factory()->create();
|
|
$role = Role::factory()->create();
|
|
|
|
$data = [$role->id => [$permission->id]];
|
|
|
|
$this->actingAs($userA)
|
|
->post('permissions/save', ['roles' => $data])
|
|
->assertStatus(403);
|
|
|
|
$this->assertDatabaseMissing('permission_role', [
|
|
'role_id' => $role->id,
|
|
'permission_id' => $permission->id,
|
|
]);
|
|
|
|
$this->actingAs($userB)
|
|
->post('permissions/save', ['roles' => $data]);
|
|
|
|
$this->assertDatabaseHas('permission_role', [
|
|
'role_id' => $role->id,
|
|
'permission_id' => $permission->id,
|
|
]);
|
|
}
|
|
|
|
/** @test */
|
|
public function save_role_permissions_if_no_permission_is_selected_for_specific_role()
|
|
{
|
|
Event::fake([
|
|
PermissionsUpdated::class,
|
|
]);
|
|
|
|
$role1 = Role::factory()->create();
|
|
$permission1 = Permission::factory()->create();
|
|
$role1->permissions()->attach($permission1->id);
|
|
|
|
$role2 = Role::factory()->create();
|
|
$permission2 = Permission::factory()->create();
|
|
$role2->permissions()->attach($permission2->id);
|
|
|
|
$this->post('/permissions/save', [
|
|
'roles' => [
|
|
$role1->id => [$permission1->id],
|
|
],
|
|
]);
|
|
|
|
$this->assertSessionHasSuccess('Permissions saved successfully.');
|
|
|
|
$this->assertDatabaseHas('permission_role', [
|
|
'role_id' => $role1->id,
|
|
'permission_id' => $permission1->id,
|
|
]);
|
|
|
|
$this->assertDatabaseMissing('permission_role', [
|
|
'role_id' => $role2->id,
|
|
'permission_id' => $permission2->id,
|
|
]);
|
|
|
|
Event::assertDispatched(PermissionsUpdated::class);
|
|
}
|
|
|
|
/** @test */
|
|
public function create_permission()
|
|
{
|
|
$this->app->instance('middleware.disable', false);
|
|
|
|
Event::fake([
|
|
Created::class,
|
|
]);
|
|
|
|
$data = $this->validParams();
|
|
|
|
$this->post('permissions', $data)
|
|
->assertRedirect('/permissions');
|
|
|
|
$this->assertSessionHasSuccess('Permission created successfully.');
|
|
$this->assertDatabaseHas('permissions', $data);
|
|
|
|
Event::assertDispatched(Created::class);
|
|
}
|
|
|
|
/** @test */
|
|
public function only_users_with_appropriate_permission_can_create_new_permissions()
|
|
{
|
|
$roleA = RoleFactory::create();
|
|
$roleB = RoleFactory::withPermissions('permissions.manage')->create();
|
|
|
|
$userA = UserFactory::role($roleA)->create();
|
|
$userB = UserFactory::role($roleB)->create();
|
|
|
|
$data = $this->validParams();
|
|
|
|
$this->actingAs($userA)
|
|
->post('permissions', $data)
|
|
->assertStatus(403);
|
|
|
|
$this->assertDatabaseMissing('permissions', $data);
|
|
|
|
$this->actingAs($userB)
|
|
->post('permissions', $data)
|
|
->assertRedirect('/permissions');
|
|
|
|
$this->assertDatabaseHas('permissions', $data);
|
|
}
|
|
|
|
/** @test */
|
|
public function permission_name_must_have_valid_format()
|
|
{
|
|
$this->app->instance('middleware.disable', false);
|
|
|
|
$data = $this->validParams();
|
|
|
|
$response = $this->post('permissions', $this->validParams(['name' => 'invalid name']));
|
|
$response->assertSessionHasErrors('name');
|
|
$this->assertDatabaseMissing('permissions', $data);
|
|
|
|
$response = $this->post('permissions', $this->validParams(['name' => 'invalid*name']));
|
|
$response->assertSessionHasErrors('name');
|
|
$this->assertDatabaseMissing('permissions', $data);
|
|
}
|
|
|
|
/** @test */
|
|
public function update_permission()
|
|
{
|
|
$this->withoutExceptionHandling();
|
|
|
|
Event::fake([
|
|
Updated::class,
|
|
]);
|
|
|
|
$permission = Permission::factory()->create();
|
|
|
|
$this->get("permissions/{$permission->id}/edit")
|
|
->assertOk()
|
|
->assertSee($permission->id)
|
|
->assertSee($permission->name)
|
|
->assertSee($permission->display_name);
|
|
|
|
$data = $this->validParams();
|
|
|
|
$this->put("permissions/{$permission->id}", $data);
|
|
|
|
$this->assertSessionHasSuccess('Permission updated successfully.');
|
|
$this->assertDatabaseHas('permissions', $data + ['id' => $permission->id]);
|
|
|
|
Event::assertDispatched(Updated::class);
|
|
}
|
|
|
|
/** @test */
|
|
public function only_users_with_appropriate_permission_can_update_existing_permissions()
|
|
{
|
|
$roleA = RoleFactory::create();
|
|
$roleB = RoleFactory::withPermissions('permissions.manage')->create();
|
|
|
|
$userA = UserFactory::role($roleA)->create();
|
|
$userB = UserFactory::role($roleB)->create();
|
|
|
|
$permission = Permission::factory()->create();
|
|
|
|
$data = $this->validParams();
|
|
|
|
$this->actingAs($userA)
|
|
->put("permissions/{$permission->id}", $data)
|
|
->assertStatus(403);
|
|
|
|
$this->assertEquals($permission->toArray(), $permission->fresh()->toArray());
|
|
|
|
$this->actingAs($userB)
|
|
->put("permissions/{$permission->id}", $data)
|
|
->assertRedirect('/permissions');
|
|
|
|
$permission->refresh();
|
|
|
|
$this->assertEquals($permission->name, $data['name']);
|
|
$this->assertEquals($permission->display_name, $data['display_name']);
|
|
$this->assertEquals($permission->description, $data['description']);
|
|
}
|
|
|
|
/** @test */
|
|
public function removable_attribute_cannot_be_changed_on_update()
|
|
{
|
|
$permission = Permission::factory()->create(['removable' => false]);
|
|
|
|
$data = $this->validParams(['removable' => true]);
|
|
|
|
$this->put("permissions/{$permission->id}", $data);
|
|
|
|
$permission->refresh();
|
|
|
|
$this->assertEquals($permission->name, $data['name']);
|
|
$this->assertEquals($permission->display_name, $data['display_name']);
|
|
$this->assertEquals($permission->description, $data['description']);
|
|
$this->assertFalse($permission->removable);
|
|
}
|
|
|
|
/** @test */
|
|
public function permission_name_must_have_valid_format_while_updating_the_permission()
|
|
{
|
|
$permission = Permission::factory()->create(['name' => 'foo']);
|
|
|
|
$response = $this->put('permissions/'.$permission->id, $this->validParams(['name' => 'invalid name']));
|
|
$response->assertSessionHasErrors('name');
|
|
$this->assertEquals('foo', $permission->fresh()->name);
|
|
|
|
$response = $this->put('permissions/'.$permission->id, $this->validParams(['name' => 'invalid*name']));
|
|
$response->assertSessionHasErrors('name');
|
|
$this->assertEquals('foo', $permission->fresh()->name);
|
|
}
|
|
|
|
/** @test */
|
|
public function delete_permission()
|
|
{
|
|
Event::fake([
|
|
Deleted::class,
|
|
]);
|
|
|
|
$permission = Permission::factory()->create();
|
|
|
|
$this->delete(route('permissions.destroy', $permission->id))
|
|
->assertRedirect('/permissions');
|
|
|
|
$this->assertSessionHasSuccess('Permission deleted successfully.');
|
|
$this->assertDatabaseMissing('permissions', ['id' => $permission->id]);
|
|
|
|
Event::assertDispatched(Deleted::class);
|
|
}
|
|
|
|
/** @test */
|
|
public function only_users_with_appropriate_permission_can_delete_permissions()
|
|
{
|
|
$roleA = RoleFactory::create();
|
|
$roleB = RoleFactory::withPermissions('permissions.manage')->create();
|
|
|
|
$userA = UserFactory::role($roleA)->create();
|
|
$userB = UserFactory::role($roleB)->create();
|
|
|
|
$permission = Permission::factory()->create();
|
|
|
|
$this->actingAs($userA)
|
|
->delete("permissions/{$permission->id}")
|
|
->assertStatus(403);
|
|
|
|
$this->assertNotNull($permission->fresh());
|
|
|
|
$this->actingAs($userB)
|
|
->delete("permissions/{$permission->id}")
|
|
->assertRedirect('/permissions');
|
|
|
|
$this->assertNull($permission->fresh());
|
|
}
|
|
|
|
/** @test */
|
|
public function non_removable_permissions_cannot_be_removed()
|
|
{
|
|
$permission = Permission::factory()->create(['removable' => false]);
|
|
|
|
$this->delete(route('permissions.destroy', $permission->id))
|
|
->assertStatus(404);
|
|
|
|
$this->assertNotNull($permission->fresh());
|
|
}
|
|
|
|
private function validParams(array $override = []): array
|
|
{
|
|
return array_merge([
|
|
'name' => 'foo_permission',
|
|
'display_name' => 'Foo Permission',
|
|
'description' => 'the description',
|
|
], $override);
|
|
}
|
|
}
|